child_process: reduce internal usage of public require of util#26769
Closed
toshi1127 wants to merge 1 commit intonodejs:masterfrom
Closed
child_process: reduce internal usage of public require of util#26769toshi1127 wants to merge 1 commit intonodejs:masterfrom
toshi1127 wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
the
child_process
shisama
approved these changes
Mar 20, 2019
Contributor
jasnell
approved these changes
Mar 21, 2019
ZYSzys
approved these changes
Mar 22, 2019
ZYSzys
added
the
author ready
BridgeAR
approved these changes
Mar 22, 2019
Member
|
Landed in 382e859 @toshi1127 congratulations for your contribution to Node.js! 🎉 |
ZYSzys
pushed a commit
that referenced
this pull request
Mar 22, 2019
PR-URL: #26769 Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos
pushed a commit
that referenced
this pull request
Mar 28, 2019
PR-URL: #26769 Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos
pushed a commit
that referenced
this pull request
Mar 30, 2019
PR-URL: #26769 Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the usage of public require('util'), as described in issue:
#26546
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes